Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "cookie" property to rpc http messages #4317

Merged
merged 10 commits into from
Jun 4, 2019
Merged

Add "cookie" property to rpc http messages #4317

merged 10 commits into from
Jun 4, 2019

Conversation

mhoeger
Copy link
Contributor

@mhoeger mhoeger commented Apr 17, 2019 •
edited
Loading

@mhoeger mhoeger requested review from pragnagopa and fabiocav May 14, 2019 22:46
@mhoeger mhoeger changed the title [DO NOT MERGE until protobuf updated] Add "cookie" property to rpc http messages Add "cookie" property to rpc http messages May 14, 2019
@mhoeger mhoeger mentioned this pull request May 14, 2019
Merged
pragnagopa
pragnagopa reviewed May 20, 2019
View reviewed changes
Copy link
Member

@pragnagopa pragnagopa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added few comments.

...bs.Script.Grpc/azure-functions-language-worker-protobuf/src/proto/shared/NullableTypes.proto Show resolved Hide resolved
src/WebJobs.Script/Binding/Http/HttpBinding.cs Outdated Show resolved Hide resolved
src/WebJobs.Script/Rpc/MessageExtensions/RpcMessageConversionExtensions.cs Outdated Show resolved Hide resolved
src/WebJobs.Script/Rpc/MessageExtensions/Utilities.cs Show resolved Hide resolved
test/WebJobs.Script.Tests/Binding/HttpBindingTests.cs Show resolved Hide resolved
src/WebJobs.Script/Binding/Http/RawScriptResult.cs Show resolved Hide resolved
pragnagopa
pragnagopa reviewed Jun 3, 2019
View reviewed changes
Copy link
Member

@pragnagopa pragnagopa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks good. Added minor comments

src/WebJobs.Script/Binding/Http/HttpBinding.cs Outdated Show resolved Hide resolved
test/WebJobs.Script.Tests/Binding/HttpBindingTests.cs Outdated Show resolved Hide resolved
test/WebJobs.Script.Tests/Binding/HttpBindingTests.cs Show resolved Hide resolved
@mhoeger mhoeger requested a review from pragnagopa June 3, 2019 22:38
pragnagopa
pragnagopa approved these changes Jun 4, 2019
View reviewed changes
Copy link
Member

@pragnagopa pragnagopa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added minor nits. Please address them before merging

@mhoeger mhoeger merged commit 81003ef into Azure:dev Jun 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pragnagopa pragnagopa pragnagopa approved these changes

@fabiocav fabiocav Awaiting requested review from fabiocav

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Better way to set cookies and other repeatable headers in Javascript Http functions
2 participants
@mhoeger @pragnagopa